Conversion to poetry project, added support for multiple ranges.#36
Conversion to poetry project, added support for multiple ranges.#36nparker2020 wants to merge 12 commits intodanvk:masterfrom
Conversation
…t. Have to validate some how with a third party tool.
…ontentType text/plain
… is currently released.
Code reorg to poetry-ify this project.
Forgot to hit save on the server script
Geez, forgetting to same everything.
|
Thanks @nparker2020. Are you interested in taking over this package? I'm happy to transfer ownership (and I'm a fan of poetry!). |
|
@danvk I sure would be! Not sure how it would work transferring the publishing and all that but happy to learn. P.S. This PR isn't quite ready there's something funny with the headers so let's wait to merge it for now. |
| [tool.poetry.dependencies] | ||
| python = "^3.8" | ||
| pytest = "^7.4.2" | ||
| pytest-cov = "^4.1.0" | ||
| coveralls = "^3.3.1" | ||
| requests-toolbelt = "^1.0.0" |
There was a problem hiding this comment.
Could you unpin the upper bound on these dependencies? Although this is more of an "application" than a "library", it's still likely to be used as a library. As such, we want to avoid pinning downstream users without good reason c.f. https://iscinumpy.dev/post/poetry-versions/
There was a problem hiding this comment.
Additionally, are any of these actually needed for runtime besides the Python version?
3 participants
Reorganized the code a bit to make it easier to work with poetry.
Converted package to be a poetry project.
Added support for requesting multiple ranges in the Range header.
Seems like you don't want to support this package anymore (fair enough) but submitting a PR like this seemed like the right thing to do.